Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodiscover memleak #41748

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Autodiscover memleak #41748

merged 7 commits into from
Jan 27, 2025

Conversation

rsafonseca
Copy link
Contributor

@rsafonseca rsafonseca commented Nov 22, 2024

Proposed commit message

Fix memory leak in autodiscovery
Before this change, start events were never removed from memory due to a permanent reference to mapstr.Clone() object containing the full event
After this change, the event is freed from memory as soon as handle_start finishes, maintaining only the metadata of the even in memory
After a stop event, all existing references to the metadata of the stopped config are now removed from the autodiscover meta map

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshots

image

Logs

@rsafonseca rsafonseca requested a review from a team as a code owner November 22, 2024 11:26
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 22, 2024
Copy link
Contributor

mergify bot commented Nov 22, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @rsafonseca? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 22, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 22, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 22, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 22, 2024
@pierrehilbert pierrehilbert requested a review from faec November 22, 2024 12:43
@rsafonseca
Copy link
Contributor Author

This is tested in a production environment and the leak seems completely resolved :)
It's been running for >24h without any errors or leaks

@rsafonseca
Copy link
Contributor Author

image
for seeing the change over the past few versions, compared with v8.16.0-wls.2 which contains the fix
image

@pierrehilbert
Copy link
Collaborator

/test

@rsafonseca
Copy link
Contributor Author

Is there anything holding this up?

@mauri870
Copy link
Member

@rsafonseca Thanks for the fix! Could you please resolve the conflicts in the changelog? This will be the last input we need from you before merging.

@rsafonseca
Copy link
Contributor Author

@rsafonseca Thanks for the fix! Could you please resolve the conflicts in the changelog? This will be the last input we need from you before merging.

done @mauri870 :)

@mauri870 mauri870 enabled auto-merge (squash) January 24, 2025 13:08
@mauri870
Copy link
Member

mauri870 commented Jan 24, 2025

Enabled auto-merge. Thanks again!

@mauri870
Copy link
Member

/test

@mauri870
Copy link
Member

run docs-build

@mauri870 mauri870 merged commit bb5032e into elastic:main Jan 27, 2025
142 checks passed
mergify bot pushed a commit that referenced this pull request Jan 27, 2025
* Create a clone to release source struct from mem

* Cleanup meta on stop events

* Add changelog entry

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit bb5032e)
mauri870 added a commit that referenced this pull request Jan 27, 2025
* Create a clone to release source struct from mem

* Cleanup meta on stop events

* Add changelog entry

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit bb5032e)

Co-authored-by: Rafael da Fonseca <rsafonseca@gmail.com>
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants