-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelconsumer: remove temporary handling of entity too large #41911
Conversation
This code was initially added in elastic#41523 because of a limitation from the elasticsearch exporter. The elasticsearch exporter has been updated to enforce flush::max_bytes for the batcher extension and will automatically split the batch if it exceeds the limit. This error is now fixed in the collector v0.115.0. See open-telemetry/opentelemetry-collector-contrib#36396.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As a follow on to this PR, can you add an integration test to the elastic-agent repo that proves that large batches get split? I want to be sure that we have a test somewhere that proves that batch splitting works.
Agree, we should have a test for this. I added to the notes in the original issue and will follow up on it. |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This code was initially added in #41523 because of a limitation from the elasticsearch exporter. The elasticsearch exporter has been updated to enforce flush::max_bytes for the batcher extension and will automatically split the batch if it exceeds the limit. This error is now fixed in the collector v0.115.0. See open-telemetry/opentelemetry-collector-contrib#36396. (cherry picked from commit dbeb9cd)
…41971) This code was initially added in #41523 because of a limitation from the elasticsearch exporter. The elasticsearch exporter has been updated to enforce flush::max_bytes for the batcher extension and will automatically split the batch if it exceeds the limit. This error is now fixed in the collector v0.115.0. See open-telemetry/opentelemetry-collector-contrib#36396. (cherry picked from commit dbeb9cd) Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
…41911) This code was initially added in elastic#41523 because of a limitation from the elasticsearch exporter. The elasticsearch exporter has been updated to enforce flush::max_bytes for the batcher extension and will automatically split the batch if it exceeds the limit. This error is now fixed in the collector v0.115.0. See open-telemetry/opentelemetry-collector-contrib#36396.
Proposed commit message
This code was initially added in #41523 because of a limitation from the elasticsearch exporter.
The elasticsearch exporter has been updated to enforce flush::bytes for the batcher extension and will automatically split the batch if it exceeds the limit.
This error is now fixed in the collector v0.115.0.
See open-telemetry/opentelemetry-collector-contrib#36396.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues