Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x](backport #42116) Add support for recursive structures in packetbeat's ECS field handlers #42283

Open
wants to merge 1 commit into
base: 8.x
Choose a base branch
from
Open

[8.x](backport #42116) Add support for recursive structures in packetbeat's ECS field handlers #42283

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 9, 2025

Proposed commit message

fixes #42108

This fixes the behavior of MarshalMapStr() so that it'll properly recurse through nested structs when turning the ecs.Fields object into a map. This might technically be a breaking change, since the process.parent field will
now produce a different (but correct) map.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
This is an automatic backport of pull request #42116 done by [Mergify](https://mergify.com).

@fearful-symmetry @mergify
Add support for recursive structures in packetbeat's ECS field handle…
d3d5e7c 
…rs (#42116)

* add support for recursive structures in ECS

* tinkering

* changelog

* fix timestamps I broke

* add tests, more checks

(cherry picked from commit 525ed30)
@mergify mergify bot requested a review from a team as a code owner January 9, 2025 17:23
@mergify mergify bot added the backport label Jan 9, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 9, 2025
@github-actions github-actions bot added bugfix Team:Security-Linux Platform Linux Platform Team in Security Solution labels Jan 9, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fearful-symmetry fearful-symmetry

Labels
backport bugfix Team:Security-Linux Platform Linux Platform Team in Security Solution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elasticmachine @fearful-symmetry