Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat] Add intermediary support for ssl.verification_mode #42368

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Jan 21, 2025

Proposed commit message

This adds support for ssl.verification_mode:none in our config translation layer for ES.

This is so that we can begin to use this parameter for our use cases.

beatsauthextension will support all modes. But specifically for ssl.verification_mode:none, we can skip adding auth extension for validation.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@khushijain21 khushijain21 requested a review from a team as a code owner January 21, 2025 15:17
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 21, 2025
Copy link
Contributor

mergify bot commented Jan 21, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 21, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 21, 2025
@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jan 21, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 21, 2025
@khushijain21 khushijain21 marked this pull request as draft January 22, 2025 04:23
@khushijain21 khushijain21 marked this pull request as ready for review January 24, 2025 15:26
@khushijain21
Copy link
Contributor Author

/test

khushijain21 and others added 2 commits January 28, 2025 20:01
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
@khushijain21 khushijain21 merged commit 3e18a38 into elastic:main Jan 28, 2025
141 checks passed
mergify bot pushed a commit that referenced this pull request Jan 28, 2025
* [filebeat] Add intermediary support for `ssl.verification_mode` on ES config translation layer

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit 3e18a38)
khushijain21 added a commit that referenced this pull request Jan 28, 2025
…) (#42461)

* [filebeat] Add intermediary support for `ssl.verification_mode` on ES config translation layer

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit 3e18a38)

Co-authored-by: Khushi Jain <khushi.jain@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants