-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Journald fields to better match ECS #42403
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
fd76f39
to
33cbd59
Compare
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
I've been looking if this PR will affect the output of the journald or system integration, the journald integration already does the same conversion as this PR using Filebeat processors (source). For the system integration, I've been looking at the code and the modified fields are either not used or get dropped. I'll run some manual tests tomorrow just to be on the safe side. |
Proposed commit message
See title
Checklist
I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Because the fields produced by the Journald input are updated to better match ECS, once the user updates Filebeat/Elastic-Agent, the events generated will be slightly different.
Author's Checklist
How to test this PR locally
Run Filebeat with the journald input:
Verify the changes:
Renamed fields:
log.syslog.priority
log.syslog.facility.code
log.syslog.appname
log.syslog.procid
Removed fields:
container.id_truncated
container.log.tag
Instead of
container.partial
, now we set the tagpartial_message
To validate that the tag
partial_message
is correctly added, extractfilebeat/input/journald/testdata/ndjson-parser.journal.gz
and ingest it with the input. There is a single event on this journal file and it containsCONTAINER_PARTIAL_MESSAGE=true
.Related issues
## Use cases## Screenshots## Logs