Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x](backport #42416) perf(add_docker_metadata): do not recompile the same regex for each cgroup path #42419

Merged
merged 1 commit into from
Jan 24, 2025
Merged

[8.x](backport #42416) perf(add_docker_metadata): do not recompile the same regex for each cgroup path #42419

merged 1 commit into from
Jan 24, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 24, 2025

Proposed commit message

the same regex is created/compiled for each cgroup path

in recent profiling data this is responsible for ~3% of auditbeat cpu usage

move it to a var outside the function to only compile it once

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #42416 done by [Mergify](https://mergify.com).

@kruskall @mergify
perf(add_docker_metadata): do not recompile the same regex for each c…
ecfa2d8 
…group path (#42416)

the same regex is created/compiled for each cgroup path

in recent profiling data this is responsible for ~3% of auditbeat cpu usage

move it to a var outside the function to only compile it once

(cherry picked from commit 366bc8e)
@mergify mergify bot added the backport label Jan 24, 2025
@mergify mergify bot requested a review from a team as a code owner January 24, 2025 10:55
@mergify mergify bot requested review from khushijain21 and VihasMakwana and removed request for a team January 24, 2025 10:55
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2025
@botelastic
Copy link

botelastic bot commented Jan 24, 2025

This pull request doesn't have a Team:<team> label.

@kruskall kruskall enabled auto-merge (squash) January 24, 2025 10:59
@kruskall kruskall merged commit d0b5b6a into 8.x Jan 24, 2025
142 checks passed
@kruskall kruskall deleted the mergify/bp/8.x/pr-42416 branch January 24, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruskall kruskall kruskall approved these changes

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@kruskall kruskall

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kruskall