[8.x](backport #42172) [tests] Fix packetbeat system tests on windows#42482
Merged
[8.x](backport #42172) [tests] Fix packetbeat system tests on windows#42482
Conversation
* Fix packetbeat system tests on windows * Add retry if needed in pre command hook * Add hook path * Undo retry changes * Remove retry in hook * Undo version change * Fix test * Do not skip npcap installation for system tests * Revert "Do not skip npcap installation for system tests" This reverts commit 90a8265. * Enable npcap installation on CI * use dot sourcing for ps * source in pre-command * test win10 image * fix image name * Revert "fix image name" This reverts commit 587a00e. * Revert "test win10 image" This reverts commit 95b7dea. * test win10 image * Revert "test win10 image" This reverts commit 7ae9b46. * Move out of hook * update gcp auth script * call script instead of dot sourcing (cherry picked from commit 2b61d40) # Conflicts: # .buildkite/x-pack/pipeline.xpack.packetbeat.yml
mergify
bot
added
backport
conflicts
Contributor
Author
|
Cherry-pick of 2b61d40 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
botelastic
bot
added
the
needs_team
github-actions
bot
added
Packetbeat
failed-test
botelastic
bot
removed
the
needs_team
Contributor
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
Contributor
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
marc-gr
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
In windows
net.Interfaces()andpcap.FindAllDevs()naming are inconsistent. This changes the way we check in tests to fallback to find them by address, making the process more robust.It also reenables npcap installation during CI tests to validate the installation process. CI windows images were rebuilt for that purpose.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Related issues
This is an automatic backport of pull request #42172 done by [Mergify](https://mergify.com).