Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve original meta fields during early encoding of events #42559

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Preserve original meta fields during early encoding of events #42559

wants to merge 6 commits into from
+26 −8

Conversation

faec
Copy link
Contributor

@faec faec commented Jan 31, 2025 •
edited
Loading

Preserve the Meta field when generating the early-encoding of an event, and include it in string representations when logging event errors/warnings.

Fixes #41725.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jan 31, 2025
@faec faec self-assigned this Jan 31, 2025
@faec faec requested a review from a team as a code owner January 31, 2025 20:44
@faec faec requested review from AndersonQ and leehinman January 31, 2025 20:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 31, 2025
@faec faec added backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Jan 31, 2025
leehinman
leehinman approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

@mauri870 mauri870 mauri870 approved these changes

@AndersonQ AndersonQ AndersonQ approved these changes

Assignees

@faec faec

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ES output] Cannot index event logs does not contain the meta field any more.
5 participants
@faec @elasticmachine @AndersonQ @mauri870 @leehinman