Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add latency metrics for logstash async output #42565

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Add latency metrics for logstash async output #42565

merged 3 commits into from
Feb 4, 2025

Conversation

strawgate
Copy link
Contributor

@strawgate strawgate commented Jan 31, 2025 •
edited
Loading

Same as #42537 but for Logstash

#37445 added latency metrics for the sync output but the async output is what's used by the default configuration

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @strawgate? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@strawgate strawgate marked this pull request as ready for review January 31, 2025 22:27
@strawgate strawgate requested a review from a team as a code owner January 31, 2025 22:27
@strawgate strawgate requested review from AndersonQ and rdner January 31, 2025 22:27
@strawgate strawgate added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Jan 31, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2025
@strawgate strawgate enabled auto-merge (squash) February 1, 2025 05:14
@strawgate strawgate mentioned this pull request Feb 3, 2025
Closed
5 tasks
AndersonQ
AndersonQ approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@AndersonQ AndersonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be feasible to add some tests? The other PR also does not have a y tests, so I'll approve it.

@strawgate strawgate merged commit accc5e1 into main Feb 4, 2025
142 checks passed
@strawgate strawgate deleted the add-logstash-async-metrics branch February 4, 2025 06:43
mergify bot pushed a commit that referenced this pull request Feb 4, 2025
@strawgate @mergify
Add latency metrics for logstash async output (#42565)
ff986f9 
* Add latency metrics for logstash async output

* Properly handle per-batch latency

(cherry picked from commit accc5e1)
mergify bot pushed a commit that referenced this pull request Feb 4, 2025
@strawgate @mergify
Add latency metrics for logstash async output (#42565)
fc9b82c 
* Add latency metrics for logstash async output

* Properly handle per-batch latency

(cherry picked from commit accc5e1)

# Conflicts:
#	libbeat/outputs/logstash/async.go
This was referenced Feb 4, 2025
Merged
Open
mergify bot pushed a commit that referenced this pull request Feb 4, 2025
@strawgate @mergify
Add latency metrics for logstash async output (#42565)
40e6c5a 
* Add latency metrics for logstash async output

* Properly handle per-batch latency

(cherry picked from commit accc5e1)
@mergify mergify bot mentioned this pull request Feb 4, 2025
Open
mergify bot pushed a commit that referenced this pull request Feb 4, 2025
@strawgate @mergify
Add latency metrics for logstash async output (#42565)
c502f20 
* Add latency metrics for logstash async output

* Properly handle per-batch latency

(cherry picked from commit accc5e1)
@mergify mergify bot mentioned this pull request Feb 4, 2025
Merged
strawgate added a commit that referenced this pull request Feb 4, 2025
@mergify @strawgate
Add latency metrics for logstash async output (#42565) (#42583)
d551e0d 
* Add latency metrics for logstash async output

* Properly handle per-batch latency

(cherry picked from commit accc5e1)

Co-authored-by: William Easton <bill.easton@elastic.co>
@strawgate strawgate mentioned this pull request Feb 4, 2025
Open
5 tasks
rdner added a commit that referenced this pull request Feb 5, 2025
@mergify @strawgate @rdner
Add latency metrics for logstash async output (#42565) (#42586)
7dd9c20 
* Add latency metrics for logstash async output

* Properly handle per-batch latency

(cherry picked from commit accc5e1)

Co-authored-by: William Easton <bill.easton@elastic.co>
Co-authored-by: Denis <denis.rechkunov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonQ AndersonQ AndersonQ approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@belimawr belimawr Awaiting requested review from belimawr

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana

Assignees

@strawgate strawgate

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strawgate @elasticmachine @AndersonQ