Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #42442) x-pack/filebeat/input/httpjson: add metrics for number of events and pages published #42587

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 4, 2025

Proposed commit message

This is intended to match the events and batches published by the CEL input, but there is no concept of batches in HTTPJSON, the nearest being paging.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #42442 done by [Mergify](https://mergify.com).

…pages published (#42442)

This is intended to match the events and batches published by the CEL
input, but there is no concept of batches in HTTPJSON, the nearest being
paging.

(cherry picked from commit 71900c4)

# Conflicts:
#	x-pack/filebeat/docs/inputs/input-httpjson.asciidoc
#	x-pack/filebeat/input/httpjson/input.go
#	x-pack/filebeat/input/httpjson/metrics.go
#	x-pack/filebeat/input/httpjson/request.go
#	x-pack/filebeat/input/httpjson/request_test.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Feb 4, 2025
@mergify mergify bot requested a review from a team as a code owner February 4, 2025 06:51
Copy link
Contributor Author

mergify bot commented Feb 4, 2025

Cherry-pick of 71900c4 has failed:

On branch mergify/bp/7.17/pr-42442
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit 71900c4d8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   x-pack/filebeat/docs/inputs/input-httpjson.asciidoc
	both modified:   x-pack/filebeat/input/httpjson/input.go
	deleted by us:   x-pack/filebeat/input/httpjson/metrics.go
	deleted by us:   x-pack/filebeat/input/httpjson/request.go
	deleted by us:   x-pack/filebeat/input/httpjson/request_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned efd6 Feb 4, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 4, 2025
@botelastic
Copy link

botelastic bot commented Feb 4, 2025

This pull request doesn't have a Team:<team> label.

@efd6 efd6 closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant