Fix excluded tags lookup to use correct key type#417
Merged
Conversation
Member
Author
|
Customer tested the changes and confirmed the fix. I think we're good to merge, after an approval. |
mattnowzari
approved these changes
Feb 6, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
### Closes #416 The `exclude_tags` configuration was not being applied correctly. The config stores exclude_tags keyed by domain URL strings (e.g., `"https://example.com"`), but the lookup in `get_body_tag` was using the URL object directly as the hash key instead of `url.site`. This fix changes the lookup to use `url.site` (which returns the scheme + host as a string) to match how the config stores the keys. ### Checklists #### Pre-Review Checklist - [x] This PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check `crawler.yml.example` and `elasticsearch.yml.example`) - [x] This PR has a meaningful title - [x] This PR links to all relevant GitHub issues that it fixes or partially addresses - Fixes #416 - [x] this PR has a thorough description - [x] Covered the changes with automated tests - [ ] Tested the changes locally - [x] Added a label for each target release version (example: `v0.1.0`) - [x] Considered corresponding documentation changes - N/A - this is a bug fix, no documentation changes needed - [x] Contributed any configuration settings changes to the configuration reference - N/A - no configuration changes - [x] Ran `make notice` if any dependencies have been added - N/A - no dependencies added #### Changes Requiring Extra Attention N/A - This is a straightforward bug fix with no security implications or new dependencies. ### Release Note Fixed `exclude_tags` domain configuration not being applied during crawl. Tags specified in `exclude_tags` for a domain are now correctly excluded from the document body.
seanstory
added a commit
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #416
The
exclude_tagsconfiguration was not being applied correctly. The config stores exclude_tags keyed by domain URL strings (e.g.,"https://example.com"), but the lookup inget_body_tagwas using the URL object directly as the hash key instead ofurl.site.This fix changes the lookup to use
url.site(which returns the scheme + host as a string) to match how the config stores the keys.Checklists
Pre-Review Checklist
crawler.yml.exampleandelasticsearch.yml.example)v0.1.0)make noticeif any dependencies have been addedChanges Requiring Extra Attention
N/A - This is a straightforward bug fix with no security implications or new dependencies.
Release Note
Fixed
exclude_tagsdomain configuration not being applied during crawl. Tags specified inexclude_tagsfor a domain are now correctly excluded from the document body.