-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Tuning] Direct Outbound SMB Connection #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samirbous
approved these changes
Jan 23, 2024
terrancedejesus
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tuning looks good.
- We removed the compatibility with the Windows integration.
- We removed the index searches for Winlogbeat and Windows integration; this should reduce the doc counts and searches in general, hopefully increasing performance of the rule at execution time
- After conversation with @w0rk3r and @Samirbous, the goal of
not (process.code_signature.trusted == true and not process.code_signature.subject_name : "Microsoft *")
is to capture unsigned executables + MS LOLbins (inherently signed).
The approach is to capture all potentially signed MS LOLbins sending direct outbound SMB connections. If this is too broad, performance-wise, we can revisit in an attempt to tune further.
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 23, 2024
* [Rule Tuning] Direct Outbound SMB Connection * Update lateral_movement_direct_outbound_smb_connection.toml (cherry picked from commit e33389b)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 23, 2024
* [Rule Tuning] Direct Outbound SMB Connection * Update lateral_movement_direct_outbound_smb_connection.toml (cherry picked from commit e33389b)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 23, 2024
* [Rule Tuning] Direct Outbound SMB Connection * Update lateral_movement_direct_outbound_smb_connection.toml (cherry picked from commit e33389b)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 23, 2024
* [Rule Tuning] Direct Outbound SMB Connection * Update lateral_movement_direct_outbound_smb_connection.toml (cherry picked from commit e33389b)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 23, 2024
* [Rule Tuning] Direct Outbound SMB Connection * Update lateral_movement_direct_outbound_smb_connection.toml (cherry picked from commit e33389b)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 23, 2024
* [Rule Tuning] Direct Outbound SMB Connection * Update lateral_movement_direct_outbound_smb_connection.toml (cherry picked from commit e33389b)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 23, 2024
* [Rule Tuning] Direct Outbound SMB Connection * Update lateral_movement_direct_outbound_smb_connection.toml (cherry picked from commit e33389b)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 23, 2024
* [Rule Tuning] Direct Outbound SMB Connection * Update lateral_movement_direct_outbound_smb_connection.toml (cherry picked from commit e33389b)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 23, 2024
* [Rule Tuning] Direct Outbound SMB Connection * Update lateral_movement_direct_outbound_smb_connection.toml (cherry picked from commit e33389b)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 23, 2024
* [Rule Tuning] Direct Outbound SMB Connection * Update lateral_movement_direct_outbound_smb_connection.toml (cherry picked from commit e33389b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: auto
Domain: Endpoint
OS: Windows
windows related rules
Rule: Tuning
tweaking or tuning an existing rule
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary