-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tuning] Event.dataset removal & Tag Addition #3451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrancedejesus
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Samirbous
approved these changes
Feb 20, 2024
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [Tuning] Removed event.dataset and added tag * [Tuning] Removed event.dataset and added tag * fixed typo --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> Removed changes from: - rules/linux/execution_shell_via_meterpreter_linux.toml - rules/linux/execution_shell_via_udp_cli_utility_linux.toml - rules/linux/privilege_escalation_suspicious_chown_fowner_elevation.toml - rules_building_block/discovery_kernel_module_enumeration_via_proc.toml - rules_building_block/discovery_linux_modprobe_enumeration.toml - rules_building_block/discovery_linux_sysctl_enumeration.toml (selectively cherry picked from commit 3484cac)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [Tuning] Removed event.dataset and added tag * [Tuning] Removed event.dataset and added tag * fixed typo --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> Removed changes from: - rules/linux/execution_shell_via_meterpreter_linux.toml - rules/linux/execution_shell_via_udp_cli_utility_linux.toml - rules/linux/privilege_escalation_suspicious_chown_fowner_elevation.toml - rules_building_block/discovery_kernel_module_enumeration_via_proc.toml - rules_building_block/discovery_linux_modprobe_enumeration.toml - rules_building_block/discovery_linux_sysctl_enumeration.toml (selectively cherry picked from commit 3484cac)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [Tuning] Removed event.dataset and added tag * [Tuning] Removed event.dataset and added tag * fixed typo --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> Removed changes from: - rules/linux/execution_shell_via_meterpreter_linux.toml - rules/linux/execution_shell_via_udp_cli_utility_linux.toml - rules/linux/privilege_escalation_suspicious_chown_fowner_elevation.toml - rules_building_block/discovery_kernel_module_enumeration_via_proc.toml - rules_building_block/discovery_linux_modprobe_enumeration.toml - rules_building_block/discovery_linux_sysctl_enumeration.toml (selectively cherry picked from commit 3484cac)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [Tuning] Removed event.dataset and added tag * [Tuning] Removed event.dataset and added tag * fixed typo --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> Removed changes from: - rules/linux/privilege_escalation_suspicious_chown_fowner_elevation.toml (selectively cherry picked from commit 3484cac)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [Tuning] Removed event.dataset and added tag * [Tuning] Removed event.dataset and added tag * fixed typo --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> Removed changes from: - rules/linux/privilege_escalation_suspicious_chown_fowner_elevation.toml (selectively cherry picked from commit 3484cac)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [Tuning] Removed event.dataset and added tag * [Tuning] Removed event.dataset and added tag * fixed typo --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> Removed changes from: - rules/linux/privilege_escalation_suspicious_chown_fowner_elevation.toml (selectively cherry picked from commit 3484cac)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [Tuning] Removed event.dataset and added tag * [Tuning] Removed event.dataset and added tag * fixed typo --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> Removed changes from: - rules/linux/privilege_escalation_suspicious_chown_fowner_elevation.toml (selectively cherry picked from commit 3484cac)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [Tuning] Removed event.dataset and added tag * [Tuning] Removed event.dataset and added tag * fixed typo --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> Removed changes from: - rules/linux/privilege_escalation_suspicious_chown_fowner_elevation.toml (selectively cherry picked from commit 3484cac)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [Tuning] Removed event.dataset and added tag * [Tuning] Removed event.dataset and added tag * fixed typo --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> (cherry picked from commit 3484cac)
protectionsmachine
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [Tuning] Removed event.dataset and added tag * [Tuning] Removed event.dataset and added tag * fixed typo --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> (cherry picked from commit 3484cac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: auto
bbr
Building Block Rules
Domain: Endpoint
OS: Linux
Rule: Tuning
tweaking or tuning an existing rule
Team: TRADE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the event.dataset == "auditd_manager.auditd" entries from the Auditd Manager rules. Additionally, it adds the "Data Source: Auditd Manager" tag to the tag list. The reasoning behind this is documented in #3430.