Skip to content

[New] WDAC Policy File by an Unusual Process #4504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2025
Merged

[New] WDAC Policy File by an Unusual Process #4504

merged 6 commits into from
Mar 4, 2025

Conversation

Samirbous
Copy link
Contributor

@Samirbous Samirbous commented Feb 28, 2025

@Samirbous Samirbous added Rule: New Proposal for new rule OS: Windows windows related rules labels Feb 28, 2025
@Samirbous Samirbous self-assigned this Feb 28, 2025
@Samirbous Samirbous requested a review from Aegrah February 28, 2025 18:30
@Samirbous Samirbous requested a review from w0rk3r February 28, 2025 18:30
Copy link
Contributor

Rule: New - Guidelines

These guidelines serve as a reminder set of considerations when proposing a new rule.

Documentation and Context

  • Detailed description of the rule.
  • List any new fields required in ECS/data sources.
  • Link related issues or PRs.
  • Include references.

Rule Metadata Checks

  • creation_date matches the date of creation PR initially merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive, considering performance for diverse environments. Non ecs fields should be added to non-ecs-schema.json if not available in an integration.
  • min_stack_comments and min_stack_version should be included if the rule is only compatible starting from a specific stack version.
  • index pattern should be neither too specific nor too vague, ensuring it accurately matches the relevant data stream (e.g., use logs-endpoint.process-* for process data).
  • integration should align with the index. If the integration is newly introduced, ensure the manifest, schemas, and new_rule.yaml template are updated.
  • setup should include the necessary steps to configure the integration.
  • note should include any additional information (e.g. Triage and analysis investigation guides, timeline templates).
  • tags should be relevant to the threat and align/added to the EXPECTED_RULE_TAGS in the definitions.py file.
  • threat, techniques, and subtechniques should map to ATT&CK always if possible.

New BBR Rules

  • building_block_type should be included if the rule is a building block and the rule should be located in the rules_building_block folder.
  • bypass_bbr_timing should be included if adding custom lookback timing to the rule.

Testing and Validation

  • Provide evidence of testing and detecting the expected threat.
  • Check for existence of coverage to prevent duplication.

@tradebot-elastic
Copy link

tradebot-elastic commented Feb 28, 2025

⛔️ Tests failed:

  • ❌ WDAC Policy File by an Unusual Process (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
    • events_validation_missing: Not tested with events

@tradebot-elastic
Copy link

tradebot-elastic commented Feb 28, 2025

⛔️ Tests failed:

  • ❌ WDAC Policy File by an Unusual Process (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
    • events_validation_missing: Not tested with events

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>
@tradebot-elastic
Copy link

tradebot-elastic commented Mar 3, 2025

⛔️ Tests failed:

  • ❌ WDAC Policy File by an Unusual Process (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
    • events_validation_missing: Not tested with events

@tradebot-elastic
Copy link

tradebot-elastic commented Mar 3, 2025

⛔️ Tests failed:

  • ❌ WDAC Policy File by an Unusual Process (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
    • events_validation_missing: Not tested with events

@tradebot-elastic
Copy link

tradebot-elastic commented Mar 4, 2025

⛔️ Tests failed:

  • ❌ WDAC Policy File by an Unusual Process (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
    • events_validation_missing: Not tested with events

@tradebot-elastic
Copy link

tradebot-elastic commented Mar 4, 2025

⛔️ Tests failed:

  • ❌ WDAC Policy File by an Unusual Process (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
    • events_validation_missing: Not tested with events

@Samirbous Samirbous merged commit b1470a4 into main Mar 4, 2025
10 checks passed
@Samirbous Samirbous deleted the P7b branch March 4, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto Domain: Endpoint OS: Windows windows related rules Rule: New Proposal for new rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants