Skip to content

[New/Tuning] NPM Shai-Hulud coverage #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[New/Tuning] NPM Shai-Hulud coverage #5368

wants to merge 17 commits into from
+404 −16

Conversation

@Samirbous
Copy link
Contributor

@Samirbous Samirbous commented Nov 26, 2025

@Samirbous Samirbous self-assigned this Nov 26, 2025
@Samirbous Samirbous added OS: Linux OS: macOS Rule: New Proposal for new rule Rule: Tuning tweaking or tuning an existing rule OS: Windows windows related rules emerging-threat labels Nov 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Rule: New - Guidelines

These guidelines serve as a reminder set of considerations when proposing a new rule.

Documentation and Context

  • Detailed description of the rule.
  • List any new fields required in ECS/data sources.
  • Link related issues or PRs.
  • Include references.

Rule Metadata Checks

  • creation_date matches the date of creation PR initially merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive, considering performance for diverse environments. Non ecs fields should be added to non-ecs-schema.json if not available in an integration.
  • min_stack_comments and min_stack_version should be included if the rule is only compatible starting from a specific stack version.
  • index pattern should be neither too specific nor too vague, ensuring it accurately matches the relevant data stream (e.g., use logs-endpoint.process-* for process data).
  • integration should align with the index. If the integration is newly introduced, ensure the manifest, schemas, and new_rule.yaml template are updated.
  • setup should include the necessary steps to configure the integration.
  • note should include any additional information (e.g. Triage and analysis investigation guides, timeline templates).
  • tags should be relevant to the threat and align/added to the EXPECTED_RULE_TAGS in the definitions.py file.
  • threat, techniques, and subtechniques should map to ATT&CK always if possible.

New BBR Rules

  • building_block_type should be included if the rule is a building block and the rule should be located in the rules_building_block folder.
  • bypass_bbr_timing should be included if adding custom lookback timing to the rule.

Testing and Validation

  • Provide evidence of testing and detecting the expected threat.
  • Check for existence of coverage to prevent duplication.

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 26, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 26, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 26, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 26, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@Samirbous Samirbous requested review from Aegrah and w0rk3r November 26, 2025 18:03
@tradebot-elastic
Copy link

tradebot-elastic commented Nov 26, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 26, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 26, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Credential Access via TruffleHog Execution (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

Aegrah
Aegrah approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@Aegrah Aegrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Aegrah
Aegrah approved these changes Nov 27, 2025
View reviewed changes
Samirbous and others added 3 commits November 27, 2025 09:50
@Samirbous @Aegrah
Update rules/cross-platform/command_and_control_curl_wget_spawn_via_n…
dce060c 
…odejs_parent.toml

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>
@Samirbous @Aegrah
Update rules/cross-platform/command_and_control_curl_wget_spawn_via_n…
20e438d 
…odejs_parent.toml

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>
@Samirbous @Aegrah
Update rules/cross-platform/command_and_control_curl_wget_spawn_via_n…
6e1e918 
…odejs_parent.toml

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>
@tradebot-elastic
Copy link

tradebot-elastic commented Nov 27, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Credential Access via TruffleHog Execution (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 27, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Credential Access via TruffleHog Execution (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 27, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Credential Access via TruffleHog Execution (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

Samirbous and others added 2 commits November 27, 2025 09:51
@Samirbous @Aegrah
Update rules/cross-platform/execution_register_github_actions_runner.…
91f09be 
…toml

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>
@Samirbous @Aegrah
Update rules/cross-platform/execution_via_github_actions_runner.toml
3fc61fa 
Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>
@tradebot-elastic
Copy link

tradebot-elastic commented Nov 27, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Credential Access via TruffleHog Execution (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 27, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Credential Access via TruffleHog Execution (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 28, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ First Time Seen GitHub Self Hosted Action Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Credential Access via TruffleHog Execution (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 28, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ First Time Seen GitHub Self Hosted Action Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Credential Access via TruffleHog Execution (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 28, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ First Time Seen GitHub Self Hosted Action Runner (kuery)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Credential Access via TruffleHog Execution (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 28, 2025 •
edited
Loading

⛔️ Test failed

Results
  • ❌ New GitHub Self Hosted Action Runner (kuery)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Credential Access via TruffleHog Execution (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Remote GitHub Actions Runner Registration (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Curl or Wget Spawned via Node.js (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aegrah Aegrah Aegrah approved these changes

@w0rk3r w0rk3r Awaiting requested review from w0rk3r

At least 2 approving reviews are required to merge this pull request.

Assignees

@Samirbous Samirbous

Labels

backport: auto emerging-threat OS: Linux OS: macOS OS: Windows windows related rules Rule: New Proposal for new rule Rule: Tuning tweaking or tuning an existing rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Samirbous @tradebot-elastic @Aegrah