Skip to content

Conversation

@Samirbous
Copy link
Contributor

@Samirbous Samirbous commented Nov 28, 2025

Added a condition to require the existence of an endpoint alert:

| eval concat_module_values = MV_CONCAT(Esql.event_module_values, ",")
// Make sure an endpoint alert is present along one of the network ones
| where concat_module_values like "*endpoint*"

N.B: Esql.event_module_values == "endpoint" or Esql.event_module_values like "endpoint" or Esql.event_module_values in ("endpoint") are not working, that's why I had to use MV_CONCAT and tested.

@Samirbous Samirbous self-assigned this Nov 28, 2025
@Samirbous Samirbous added the Rule: Tuning tweaking or tuning an existing rule label Nov 28, 2025
@github-actions
Copy link
Contributor

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 28, 2025

⛔️ Test failed

Results
  • ❌ Elastic Defend and Network Security Alerts Correlation (esql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@Samirbous Samirbous requested review from Aegrah and w0rk3r November 28, 2025 10:24
@tradebot-elastic
Copy link

tradebot-elastic commented Dec 1, 2025

⛔️ Test failed

Results
  • ❌ Elastic Defend and Network Security Alerts Correlation (esql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@w0rk3r w0rk3r merged commit bcd1b50 into main Dec 1, 2025
13 checks passed
@w0rk3r w0rk3r deleted the Samirbous-patch-1 branch December 1, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport: auto Rule: Tuning tweaking or tuning an existing rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants