-
Notifications
You must be signed in to change notification settings - Fork 29
Add staging elastic nav feature flag for edge environment #1908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: reakaleek <16325797+reakaleek@users.noreply.github.com>
Copilot finished work on behalf of
reakaleek
September 18, 2025 10:45
reakaleek
reviewed
Sep 18, 2025
reakaleek
approved these changes
Sep 18, 2025
Co-authored-by: reakaleek <16325797+reakaleek@users.noreply.github.com>
reakaleek
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Copilot finished work on behalf of
reakaleek
September 18, 2025 10:50
reakaleek
approved these changes
Sep 18, 2025
reakaleek
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reakaleek
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new feature flag
STAGING_ELASTIC_NAV
that allows the edge environment to use the staging elastic navigation script fromhttps://stag-www.elastic.co/elastic-nav.js
instead of the production script athttps://www.elastic.co/elastic-nav.js
.Changes
Added
StagingElasticNavEnabled
Feature FlagFeatureFlags.cs
that maps to thestaging-elastic-nav
keyModified Header Template Logic
_Header.cshtml
to conditionally select the elastic nav script URL based on the feature flagStagingElasticNavEnabled
is true: useshttps://stag-www.elastic.co/elastic-nav.js
https://www.elastic.co/elastic-nav.js
(existing behavior)Environment Configuration
STAGING_ELASTIC_NAV: true
only in the edge environment inassembler.yml
Environment Behavior
STAGING_ELASTIC_NAV: true
https://stag-www.elastic.co/elastic-nav.js
https://www.elastic.co/elastic-nav.js
https://www.elastic.co/elastic-nav.js
https://www.elastic.co/elastic-nav.js
This change allows the web team to test the new elastic navigation from their staging environment in the edge docs build while keeping all other environments stable and using the production navigation.
Fixes #1907.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.