Fix _static folder required during release builds #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamlined static file provider logic for clarity and flexibility, especially in debug scenarios. Enhanced link parsing to emit warnings for missing URLs and improve error handling for file paths. Added new tests to validate behavior of relative image links. Before this PR a `_static` folder was required in `RELEASE` builds in documentation folders. This removes our `_static` folder and moves the files closer to their usage. This also fixes an issue where relative image links did not resolve correctly and were emitting empty src attributes.
reakaleek
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamlined static file provider logic for clarity and flexibility, especially in debug scenarios. Enhanced link parsing to emit warnings for missing URLs and improve error handling for file paths. Added new tests to validate behavior of relative image links.
Before this PR a
_staticfolder was required inRELEASEbuilds in documentation folders.This removes our
_staticfolder and moves the files closer to their usage.This also fixes an issue where relative image links did not resolve correctly and were emitting empty src attributes.