Limit diagnostics output and enhance logging clarity #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced pagination for diagnostics console output to handle only the first 100 errors/warnings and added clear messages for truncated results. Improved logging consistency in various components and added null safety when reading Git-related data. This PR also caught a performance regression in the handling of codeblocks. It was too eagerly trying to attempt substitutions on each line.
Simplified code substitution checks and improved callout parsing by introducing length constraints and better inline match detection. Adjusted interpolation to skip unnecessary substitutions for efficiency.
reakaleek
approved these changes
Jan 15, 2025
reakaleek
reviewed
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced pagination for diagnostics console output to handle only the first 100 errors/warnings and added clear messages for truncated results. Improved logging consistency in various components and added null safety when reading Git-related data.
This PR also caught a performance regression in the handling of codeblocks. It was too eagerly trying to attempt substitutions on each line.