Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for nested and indented inline anchors #359

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jan 28, 2025

Introduced new tests to verify inline anchor generation within definition lists and indented code blocks. Ensures proper HTML output and validates parsing behavior to prevent future regressions.

This removes indented code support from our parsers.

The problem was that during our minimal parse phase anchors that lived in indented code (lists/definition lists) was not discovered because they were marked as part of an indented code block.

Removing support for indented code blocks since all code should be included through fenced blocks.

### Connection modes [sniff-proxy-modes] 

$$$sniff-mode$$$

term
:   def
    Sniff mode is the default connection mode.

    $$$gateway-nodes-selection$$$

We parse documents twice, once minimally with only the parsers needed to extract metadata and once fully when we actually convert the markdown to HTML.

Our minimal parse was not picking up on the inline anchors in defininition lists because during minimal parsing these are considered indented code blocks. While our full parser did.
This meant that we were emitting the anchors in HTML but the builder model did not resulting in resolve issues.

I fixed this by removing support for indented code blocks alltogether. We want all our code to be marked with fenced blocks.

Introduced new tests to verify inline anchor generation within definition lists and indented code blocks. Ensures proper HTML output and validates parsing behavior to prevent future regressions.

This removes indented code support from our parsers.

The problem was that during our minimal parse phase anchors that lived in indented code (lists/definition lists) was not discovered because they were marked as part of an indented code block.

Removing support for indented code blocks since all code should be included through fenced blocks.

(cherry picked from commit 81d20d2)
@Mpdreamz Mpdreamz requested a review from reakaleek January 28, 2025 13:12
@Mpdreamz Mpdreamz merged commit 30e0d03 into main Jan 28, 2025
5 checks passed
@Mpdreamz Mpdreamz deleted the fix/indented-code-parsing-2 branch January 28, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested inline anchors break definition lists & fail link checking
2 participants