Add tests for nested and indented inline anchors #359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new tests to verify inline anchor generation within definition lists and indented code blocks. Ensures proper HTML output and validates parsing behavior to prevent future regressions.
This removes indented code support from our parsers.
The problem was that during our minimal parse phase anchors that lived in indented code (lists/definition lists) was not discovered because they were marked as part of an indented code block.
Removing support for indented code blocks since all code should be included through fenced blocks.
We parse documents twice, once minimally with only the parsers needed to extract metadata and once fully when we actually convert the markdown to HTML.
Our minimal parse was not picking up on the inline anchors in defininition lists because during minimal parsing these are considered indented code blocks. While our full parser did.
This meant that we were emitting the anchors in HTML but the builder model did not resulting in resolve issues.
I fixed this by removing support for indented code blocks alltogether. We want all our code to be marked with fenced blocks.