Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version docs #451
version docs #451
Changes from 54 commits
f25efff
6c7de93
fbb667e
1b640f8
87f36b6
d6e76d6
55c90f5
f4081e9
dd0c5f1
353997d
63ecd4c
d69e5ec
9faf685
445d006
d98bbab
320ec37
70db05b
2666675
38a2ee8
e360e40
5bffa52
85efd02
418000d
b5929d5
a05cfa6
8a89665
1d711a7
b6fb27c
9b60757
78e2c13
1c4dd6d
91bfbe1
aac72a2
0a0a6ca
d51f2eb
74959f6
bff3740
7ec9430
c400293
a2023d6
4033b03
354f4eb
5459f12
c61993d
8a1c465
0fccc40
30c134a
afe95d3
4dd2fdb
14d11ec
ff0dd2c
84f6861
76b9af9
7f71ed6
9a90891
ab2a705
50e5b8a
1aded31
7fa5f3e
63e0e64
7f68ab4
c2461da
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List item suffixes are overcomplicating our solution to this problem. In this example, we should use
In Elastic Stack 9.0.0, each space has its own navigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that if we're not going to be able to get line-level callouts, this use of square bracketed suffixes is not ideal. The only place I've seen a potentially compelling need for line-level callout so far is related to #108 where some reference content has things like
[beta]
in the migrated output. e.g. https://github.com/elastic/asciidocalypse/blob/reference/docs/ecs/docs/reference/ecs/ecs-cloud.md#field-sets-that-can-be-nested-under-cloud-ecs-cloud-nestings. I haven't yet played with what option (paragraph level admonitions?) will work in reference tables like that.@KOTungseth Should we hang onto this list suffix section until we've thoroughly confirmed there's no sufficiently compelling use cases for line-level admonitions? Or remove it and revisit only after it's proven that there's an undeniable use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this example, this is a learn more link that should send users to a page with the
Elastic Cloud Hosted
,Elastic Cloud Enterprise
, andElastic Cloud on Kubernetes
tags at the top of the page.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is our use case to compare Serverless vs Elastic Stack? Or Serverless vs Elastic Stack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the intention in this particular case is to compare the "Elastic Cloud Serverless" behaviour vs all the other contexts where the relevant Elastic Stack features are supported (e.g. self-managed and all other Cloud contexts). The problem is we still don't have a word for the "everything but serverless" context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary. This should appear as:
Admin
or equivalentkibana_admin
or equivalent