Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace references to text_expansion with sparse_vector #39

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Replace references to text_expansion with sparse_vector #39

merged 1 commit into from
Jul 8, 2024

Conversation

kderusso
Copy link
Member

@kderusso kderusso commented Jul 1, 2024

This PR replaces references to the deprecated text_expansion query with sparse_vector, and references to the deprecated sub_searches code path with references to retrievers instead.

@kderusso kderusso requested a review from a team as a code owner July 1, 2024 15:31
@elasticdocs
Copy link
Collaborator

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@kderusso kderusso requested a review from a team July 8, 2024 18:06
leemthompo
leemthompo approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kderusso!

@kderusso kderusso merged commit 36a2742 into elastic:main Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo approved these changes

Assignees
No one assigned
Labels
ci:doc-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kderusso @elasticdocs @leemthompo @shainaraskas