elftoolchain rework, update and change how we import things #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial import of elftoolchain/libelf with only the files we are
really going to use.
This commit has no modification to any of the files, except for a new file
`commit` added so that we can track our starting point, it tracks the commit of
upstream elftoolchain.
A non-complete list of what has NOT been imported:
- addr2line/
- ar/
- as/
- brandelf/
- cxxfilt/
- documentation/
- elfcopy/
- elfdump/
- findtextrel/
- GNUmakefile
- INSTALL
- isa/
- ld/
- libdwarf/
- libelftc/
- libpe/
- Makefile
- mk/
- nm/
- readelf/
- README.rst
- RELEASE-NOTES
- size/
- strings/
- test/
- tools/
- libelf/{Makefile, *.3, *.cat3}
- common/Makefile
- common/sys/Makefile
The next commit has all the changes and additions we did to make this work
nicely with quark and a recent libbpf.
Separated in its own commit so we can actually read the diff.
It works but I'm not happy. It's missing the whole bmake pruning, and figuring out if we should bother tracking dependencies, since cmake does its own thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an in progress port of the elftoolchain work from quark.
Since this is nasty and ungrateful work, I tried to split the commits to make this readable.
First one basically rm -rf contrib/elftoolchain, then import things verbatim, then import the interesting things. So if you're looking at this commit, ignore the first ones.
Once this is done, next step is cleaning up and updating libbpf, which should now work with this elftoolchain without any changes.