Ensure correct embedded logical name for UParser.regexes.cs (#452)

elastic · Oct 3, 2024 · 5080b07 · 5080b07
1 parent 5b4004c
commit 5080b07
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 13 deletions.
diff --git a/examples/aspnetcore-with-serilog/appsettings.Development.json b/examples/aspnetcore-with-serilog/appsettings.Development.json
@@ -3,7 +3,8 @@
     "LogLevel": {
       "Default": "Information",
       "Microsoft": "Warning",
-      "Microsoft.Hosting.Lifetime": "Information"
+      "Microsoft.Hosting.Lifetime": "Information",
+      "Elastic.Apm": "Error"
     }
   }
 }
diff --git a/examples/aspnetcore-with-serilog/appsettings.json b/examples/aspnetcore-with-serilog/appsettings.json
@@ -3,7 +3,8 @@
     "LogLevel": {
       "Default": "Information",
       "Microsoft": "Warning",
-      "Microsoft.Hosting.Lifetime": "Information"
+      "Microsoft.Hosting.Lifetime": "Information",
+      "Elastic.Apm": "Error"
     }
   },
   "AllowedHosts": "*"

diff --git a/src/Elastic.Serilog.Enrichers.Web/Elastic.Serilog.Enrichers.Web.csproj b/src/Elastic.Serilog.Enrichers.Web/Elastic.Serilog.Enrichers.Web.csproj
@@ -25,7 +25,7 @@
 
   <ItemGroup>
     <None Remove="Lib\UAParser.regexes.yaml" />
-    <EmbeddedResource Include="Lib\UAParser.regexes.yaml" />
+    <EmbeddedResource Include="Lib\UAParser.regexes.yaml" LogicalName="UAParser.regexes.yaml" />
   </ItemGroup>
 
 </Project>
diff --git a/src/Elastic.Serilog.Enrichers.Web/HttpContextEnricher.cs b/src/Elastic.Serilog.Enrichers.Web/HttpContextEnricher.cs
@@ -38,16 +38,17 @@ public HttpContextEnricher(IHttpContextAccessor httpContextAccessor) =>
 	/// <summary> Enrich the log event.</summary>
 	public void Enrich(LogEvent logEvent, ILogEventPropertyFactory propertyFactory)
 	{
-		var r = new HttpContextEnrichments();
-		if (Adapter.HasContext)
-		{
-			r.Http = Adapter.Http;
-			r.Server = Adapter.Server;
-			r.Url = Adapter.Url;
-			r.UserAgent = Adapter.UserAgent;
-			r.Client = Adapter.Client;
-			r.User = Adapter.User;
-		}
+		if (!Adapter.HasContext)
+			return;
+
+		var r = new HttpContextEnrichments {
+			Http = Adapter.Http,
+			Server = Adapter.Server,
+			Url = Adapter.Url,
+			UserAgent = Adapter.UserAgent,
+			Client = Adapter.Client,
+			User = Adapter.User
+		};
 
 		logEvent.AddPropertyIfAbsent(new LogEventProperty(PropertyName, new ScalarValue(r)));
 	}