-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip integration tests for changes that do not modify Go source files #3674
Comments
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
https://github.com/buildkite-plugins/monorepo-diff-buildkite-plugin might be the easiest way to implement this. |
That's relatively easy. Can raise a PR today |
I don't see anything related to skipping the extended pipeline based on the files that changed in a commit, but maybe I am misunderstand how this works. If someone commits a changelog fragment or changes the README, how are we avoiding running the integration tests? |
Reopening, we are still running integration tests in situations where it makes no sense to do so. For example a dependabot configuration change was blocked by failing integration tests #4802 |
Reopening since the change had to be partially reverted: #4866 https://elastic.slack.com/archives/C0522G6FBNE/p1717677463888959 Need to decide how to handle scenarios where the integration tests are skipped as unnecessary, but the integration tests are a required check in Github PRs. |
We should skip running integration tests (or unit tests but integration tests are the most expensive) for changes in PRs that modify files that are unused in tests and cannot affect them:
Current examples are:
The text was updated successfully, but these errors were encountered: