Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip integration tests for changes that do not modify Go source files #3674

Closed
cmacknz opened this issue Oct 30, 2023 · 8 comments · Fixed by #4738, #4739 or #4836
Closed

Skip integration tests for changes that do not modify Go source files #3674

cmacknz opened this issue Oct 30, 2023 · 8 comments · Fixed by #4738, #4739 or #4836
Assignees
Labels

Comments

@cmacknz
Copy link
Member

cmacknz commented Oct 30, 2023

We should skip running integration tests (or unit tests but integration tests are the most expensive) for changes in PRs that modify files that are unused in tests and cannot affect them:

Current examples are:

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@cmacknz
Copy link
Member Author

cmacknz commented Mar 22, 2024

https://github.com/buildkite-plugins/monorepo-diff-buildkite-plugin might be the easiest way to implement this.

@pazone
Copy link
Contributor

pazone commented May 13, 2024

That's relatively easy. Can raise a PR today

@jlind23
Copy link
Contributor

jlind23 commented May 15, 2024

@pazone am I right to assume that this one will be definitely close once #4739 land?

@cmacknz
Copy link
Member Author

cmacknz commented May 17, 2024

I don't see anything related to skipping the extended pipeline based on the files that changed in a commit, but maybe I am misunderstand how this works.

If someone commits a changelog fragment or changes the README, how are we avoiding running the integration tests?

@cmacknz
Copy link
Member Author

cmacknz commented May 23, 2024

Reopening, we are still running integration tests in situations where it makes no sense to do so.

For example a dependabot configuration change was blocked by failing integration tests #4802

@rowlandgeoff
Copy link
Contributor

Reopening since the change had to be partially reverted: #4866

https://elastic.slack.com/archives/C0522G6FBNE/p1717677463888959

Need to decide how to handle scenarios where the integration tests are skipped as unnecessary, but the integration tests are a required check in Github PRs.

@rowlandgeoff rowlandgeoff reopened this Jun 6, 2024
@pazone
Copy link
Contributor

pazone commented Jun 17, 2024

#4943

@pazone pazone closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants