-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Separated extended testing pipeline #4739
Conversation
This pull request does not have a backport label. Could you fix it @pazone? 🙏
NOTE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pazone I don't see anything where we add the required check for PRs to have a green build of the new pipeline... Did I miss it or you still need to add it ?
Looking at the checks for this PR I would say we definitely didn't add the required check in GH 😅
and the only listed buildkite build does not contain any integration testing...
If we need to merge the pipeline definition before the GH PR check then we should not remove the existing steps for integration testing until we are fully set up with the new pipeline and check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to hold off merging this until we have the check for the extended testing pipeline on GH PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove the request changes review, but I am still worried that some bug may be merged while there are no integration tests running since this PR is removing those steps and there will be no replacement until the new pipeline is created and the check added in the GH repo settings as pointed out by @rdner
Why are this and #4738 not a single PR? |
044a386
to
71e9149
Compare
First PR creates the new pipeline on |
c3c9120
to
ac81ab8
Compare
Found a problem with packaging after extracting the pipeline. Solving it |
Quality Gate passedIssues Measures |
* Separated extended testing pipeline * remaned to integration pipeline * Added concurrency group and BEAT_NAME * removed BEAT_NAME var from Serverless Beats tests (cherry picked from commit 6380ea5) # Conflicts: # .buildkite/pipeline.yml
* Separated extended testing pipeline * remaned to integration pipeline * Added concurrency group and BEAT_NAME * removed BEAT_NAME var from Serverless Beats tests (cherry picked from commit 6380ea5)
* Separated extended testing pipeline * remaned to integration pipeline * Added concurrency group and BEAT_NAME * removed BEAT_NAME var from Serverless Beats tests (cherry picked from commit 6380ea5) Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
What does this PR do?
Depends on #4738
Extracting long running integration tests to a separate pipeline.
Added changeset filters to the main the new pipeline
Added notification context for integration tests
Important: Introduces a concurrency group for each type of exteneded tests. The concurrency groups are limited to
8
. That means we can run only 8 jobs of a type simultaneouslyFor example:
Why is it important?
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself