-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E2E Testing] mage targets to interact with VMs and cloud stack #3887
Conversation
This pull request does not have a backport label. Could you fix it @belimawr? 🙏
NOTE: |
1d8d82e
to
4a09ffb
Compare
cbe8051
to
c006ea8
Compare
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall these targets look very useful and could be very helpful for debugging. I gave some suggestions on the naming of the targets.
In general I think these items would be better inside of the pkg/testing/runner
directly. Would be much cleaner then being into the mage file.
Thanks for the suggestions @blakerouse! I implemented them on 8c06e69. |
This commit adds a number of mage targets to improve developer experience when using the integration test framework. Those targets aim to easy how to login into VMs and run tests from there as well as how to access the Cloud Stacks. The targets added are: - integration:deployDebugTools - integration:deployEnvFile - integration:generateEnvFile - integration:listStacks - integration:listVMs - integration:printState - integration:sshvm
8c06e69
to
fd6cc21
Compare
I agree. I kept it in the magefile because it was a OnWeek project and I didn't have much time. I agree we should move it there later. |
Setting back to draft for now. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
The Goal
That's my OnWeek project, I focused on getting something simple that works, so I ended up not using most of the
runner
package/features because they're looked too coupled with running a test/set of tests and I was looking for easy and simple ways to interact directly with the VMs and Cloud Stacks.The part installs tools on a VM is not very smart, it focus on not breaking if called multiple times rather than being super efficient.
What does this PR do?
This commit adds a number of mage targets to improve developer experience when using the integration test framework. Those targets aim to easy how to login into VMs and run tests from there as well as how to access the Cloud Stacks.
The targets added are:
Why is it important?
It improves developer experience
Checklist
- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry in./changelog/fragments
using the changelog tool- [ ] I have added an integration test or an E2E test## Author's ChecklistHow to test this PR locally
Just run any of the new mage targets.
Related issues
## Use cases## ScreenshotsLogs
Some example output from the new targets
Questions to ask yourself