Disable Go Workspaces when executing 'go list' in agent packaging process #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
added
enhancement
AndersonQ
force-pushed
the
disable-go-workspaces-on-package
branch
2 times, most recently
from
ea1082d to
da84124
Compare
running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself.
AndersonQ
force-pushed
the
disable-go-workspaces-on-package
branch
from
da84124 to
8f49998
Compare
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This was referenced Jan 10, 2024
rdner
approved these changes
Jan 12, 2024
pchila
approved these changes
Jan 15, 2024
|
AndersonQ
added a commit
that referenced
this pull request
Jan 31, 2024
…cess (#4039) (#4113) running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself. (cherry picked from commit bccb12e) Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disable Go Workspaces when executing 'go list' in agent packaging process
Why is it important?
Running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself.
Therefore if Go workspaces is enabled, packaging the agent will fail
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
elastic-agent-client,elastic-agent-libsmage packageRelated issues
Questions to ask yourself