Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixingspacek8s templates #4610

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Fixingspacek8s templates #4610

merged 3 commits into from
Apr 24, 2024

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Apr 23, 2024

  • Bug

What does this PR do?

Adding newline and removing space from k8s templates that are auto-generated.
The m

Why is it important?

The issue reported here
Part of elastic/kibana#181213 (comment)

How to test this PR locally

  1. Clone elastic-agent repo
  2. cd elastic-agent/deploy/kubernetes
  3. WITHOUTCONFIG=true make generate-k8s
  4. ./creator_k8s_manifest.sh .

The elastic_agent_manifest.ts should include the generated k8s template

Related issues

@gizas gizas requested a review from a team as a code owner April 23, 2024 08:12
@mergify mergify bot assigned gizas Apr 23, 2024
Copy link
Contributor

mergify bot commented Apr 23, 2024

This pull request does not have a backport label. Could you fix it @gizas? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@gizas gizas merged commit adef7f7 into main Apr 24, 2024
9 checks passed
@gizas gizas deleted the fixingspacek8s_templates branch April 24, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants