Skip to content

[CI] Disable scheduled BK integration tests #6348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Dec 17, 2024

What does this PR do?

For testing purposes, we created a scheduled pipeline that was running every 6 hours. Now, it's not needed because its stability has been proven

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@rowlandgeoff
Copy link
Contributor

Don't you just want to remove the schedule, not the whole pipeline?

@pazone
Copy link
Contributor Author

pazone commented Jan 20, 2025

Don't you just want to remove the schedule, not the whole pipeline?

Is there a reason why we need it?

@rowlandgeoff
Copy link
Contributor

Don't you just want to remove the schedule, not the whole pipeline?

Is there a reason why we need it?

I agree with the goal of removing the schedule, but this pipeline is called by every run of the elastic-agent-extended-testing pipeline to run the integration tests. This change would delete the pipeline, not just remove the schedule.

Copy link

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is about disabling, rather than deleting the pipeline, right?

@pazone pazone changed the title [CI] Delete temporary pipeline for BK integration tests [CI] Disable scheduled BK integration tests Jan 30, 2025
@pazone
Copy link
Contributor Author

pazone commented Jan 30, 2025

@dliappis Updated the title

@pazone pazone merged commit 662b336 into main Jan 30, 2025
10 checks passed
@pazone pazone deleted the ci_delete_bk_schedulted_it branch January 30, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants