Fix flaky test TestUpgradeHandlerSameVersion #6476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased the maximum timeout to a generous 1 second. This does not extend the normal test execution time, so no reason to make this timeout too restrictive.
andrzej-stencel
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
pkoutsovasilis
approved these changes
Jan 3, 2025
andrzej-stencel
deleted the
fix-flaky-test-TestUpgradeHandlerSameVersion
branch
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Increased the maximum timeout to a generous 1 second. This does not extend the normal test execution time, so no reason to make this timeout too restrictive. (cherry picked from commit 8325d47)
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Increased the maximum timeout to a generous 1 second. This does not extend the normal test execution time, so no reason to make this timeout too restrictive. (cherry picked from commit 8325d47)
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Increased the maximum timeout to a generous 1 second. This does not extend the normal test execution time, so no reason to make this timeout too restrictive. (cherry picked from commit 8325d47)
This was referenced Jan 7, 2025
andrzej-stencel
added a commit
that referenced
this pull request
Jan 7, 2025
Increased the maximum timeout to a generous 1 second. This does not extend the normal test execution time, so no reason to make this timeout too restrictive. (cherry picked from commit 8325d47) Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel
added a commit
that referenced
this pull request
Jan 7, 2025
Increased the maximum timeout to a generous 1 second. This does not extend the normal test execution time, so no reason to make this timeout too restrictive. (cherry picked from commit 8325d47) Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel
added a commit
that referenced
this pull request
Jan 7, 2025
Increased the maximum timeout to a generous 1 second. This does not extend the normal test execution time, so no reason to make this timeout too restrictive. (cherry picked from commit 8325d47) Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix flaky test TestUpgradeHandlerSameVersion by increasing the maximum timeout to a generous 1 second. This does not extend the normal test execution time, so no reason to make this timeout too restrictive.
Why is it important?
We don't want flaky tests.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testRelated issues