Tidy mage package output: only display links on failure, fix failing fleet config embed
#6547
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmacknz
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mage packagetarget by only showing the verified links in the OTel readme if one of them fails to verify.--outflag before our own code did. So I changed the flag to--outputand now it works properly. The config comments are slightly different than the last time this worked so the file embedded it also changed.Why is it important?
It isn't but it was bothering me every time I packaged the agent.
Disruptive User Impact
You will no longer get the satisfaction of seeing that each individual URL in our OTel README is valid.
How to test this PR locally
mage checkis the fastest way to see the differences.