Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add receivercreator and k8sobserver otel components #6561

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Add receivercreator and k8sobserver otel components #6561

merged 3 commits into from
Jan 23, 2025

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 21, 2025 •
edited
Loading

What does this PR do?

This PR adds receivercreator and k8sobserver components to EDOT collector.

Why is it important?

By inlcuding receivercreator along with its dependency k8sobserver we can cover autodiscovery scenarios on K8s.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@ChrsMark
Add receivercreator and k8sobserver otel components
7a6ca0a 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from a team as a code owner January 21, 2025 12:38
@ChrsMark ChrsMark self-assigned this Jan 21, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 21, 2025

This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 21, 2025

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 21, 2025
@ChrsMark
mage update
b841528 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark enabled auto-merge (squash) January 22, 2025 10:33
@ChrsMark ChrsMark mentioned this pull request Jan 22, 2025
Open
@swiatekm swiatekm added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jan 22, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ChrsMark ChrsMark merged commit 176f6e8 into elastic:main Jan 23, 2025
15 checks passed
mergify bot pushed a commit that referenced this pull request Jan 23, 2025
@ChrsMark @mergify
Add receivercreator and k8sobserver otel components (#6561)
3a8c74b 
* Add receivercreator and k8sobserver otel components

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

* mage update

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

---------

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
(cherry picked from commit 176f6e8)
@mergify mergify bot mentioned this pull request Jan 23, 2025
Merged
8 tasks
ChrsMark added a commit that referenced this pull request Jan 27, 2025
@mergify @ChrsMark @jlind23
Add receivercreator and k8sobserver otel components (#6561) (#6580)
9d22302 
* Add receivercreator and k8sobserver otel components

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

* mage update

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

---------

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
(cherry picked from commit 176f6e8)

Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
Co-authored-by: Julien Lind <julien.lind@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@ChrsMark ChrsMark

Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrsMark @elasticmachine @michalpristas @swiatekm