Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis and nginx otel receivers #6627

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

ChrsMark
Copy link
Member

What does this PR do?

This PR adds the redis and nginx opentelemetry receiver components to EDOT.

Why is it important?

These 2 receivers will provide support for metrics collection from NGINX and Redis workloads.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from a team as a code owner January 29, 2025 14:23
@ChrsMark ChrsMark requested review from swiatekm and pchila January 29, 2025 14:23
Copy link
Contributor

mergify bot commented Jan 29, 2025

This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 29, 2025

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 29, 2025
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
@andrzej-stencel andrzej-stencel enabled auto-merge (squash) January 29, 2025 15:16
@swiatekm swiatekm added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jan 29, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@andrzej-stencel andrzej-stencel merged commit 300d88e into elastic:main Jan 30, 2025
14 checks passed
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
* Add redis and nginx otel receivers

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>

---------

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
(cherry picked from commit 300d88e)

# Conflicts:
#	internal/pkg/otel/README.md
jlind23 pushed a commit that referenced this pull request Feb 3, 2025
* Add redis and nginx otel receivers (#6627)

* Add redis and nginx otel receivers

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>

---------

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
(cherry picked from commit 300d88e)

# Conflicts:
#	internal/pkg/otel/README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
@jlind23 jlind23 added the backport-8.18 Automated backport to the 8.18 branch label Feb 3, 2025
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
* Add redis and nginx otel receivers

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

* Apply suggestions from code review

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>

---------

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
(cherry picked from commit 300d88e)

# Conflicts:
#	internal/pkg/otel/README.md
ChrsMark pushed a commit that referenced this pull request Feb 3, 2025
* Add redis and nginx otel receivers (#6627)

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants