[8.17](backport #6068) re-enable otel subcommand on Windows #6628
+50
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* move processing windows events earlier in the boot process * add Windows to otel integration tests (cherry picked from commit 8e83ce0)
mergify
bot
requested review from
kaanyalti and
andrzej-stencel
and removed request for
a team
jlind23
approved these changes
Jan 29, 2025
andrzej-stencel
approved these changes
Jan 29, 2025
|
@andrzej-stencel Not sure the lint error should be a blocker in this case. Thoughts? |
|
I think this change might depend on #5767, which hasn't been backported to 8.17. @leehinman do you remember? |
|
Tried to automatically create a backport for #6629 but looks like there are a lot of conflicts 😢 |
It does depend on #5767. Not sure why that wasn't backported. @blakerouse do you happen to remember? |
|
|
I'll close this PR without merging, as we're not eager to have this in 8.17. This should go into 8.18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
Previously when Windows was added,
elastic-agentdid not respond to the Windows Service manager quickly enough that it was starting and was deemed "unresponsive". Moving the go routine that responds to the Windows Service Manager earlier in the boot process should make this less likely. Given go's design of DLL loading and init code we can't eliminate this completely.Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
None.
How to test this PR locally
Related issues
Questions to ask yourself
This is an automatic backport of pull request #6068 done by [Mergify](https://mergify.com).