-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] Add tests for agent.monitoring to otel format #6801
base: main
Are you sure you want to change the base?
Conversation
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label. Could you fix it @khushijain21? 🙏
|
c45b743
to
cdda948
Compare
cdda948
to
d99c931
Compare
Waiting on #6837 for this PR to be ready |
From the looks of it, none of the update steps interact with each other, so I don't see a reason to run them serially. As an example, making a single line change in the otel components file results in the following timings: parallel mage update 9.19s user 1.92s system 366% cpu 3.027 total serial mage update 20.20s user 2.93s system 181% cpu 12.748 total
…lastic#6532) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.1.1 to 6.2.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6.1.1...v6.2.0) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…lastic#6604) Bumps [updatecli/updatecli-action](https://github.com/updatecli/updatecli-action) from 2.75.0 to 2.77.0. - [Release notes](https://github.com/updatecli/updatecli-action/releases) - [Commits](updatecli/updatecli-action@4aca518...79983ec) --- updated-dependencies: - dependency-name: updatecli/updatecli-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add statePersistence value to helm chart presets
* dos2unix NOTICE.txt * add dos2unix step to notice generator
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have nitpicks regarding the test, the test is also failing,
I think you're missing some ignore fields, for example the buildkite output shows differences with the cloud.instance.id and name (among other fields):
+- "cloud.instance.id": string("6692864320899608549"),
--
| ++ "cloud.instance.id": string("5902608334348578789"),
| + "cloud.instance.name": strings.Join({
| + "bk-agent-prod-gcp-1740034313",
| +- "605048021",
| ++ "705811855",
| + }, ""),
var otelDocs estools.Documents | ||
require.Eventually(t, | ||
func() bool { | ||
findCtx, findCancel := context.WithTimeout(context.Background(), 10*time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
findCtx, findCancel := context.WithTimeout(context.Background(), 10*time.Second) | |
findCtx, findCancel := context.WithTimeout(ctx, 10*time.Second) |
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
|
What does this PR do?
It adds tests for comparing docs ingested by
agent.monitoring
vs otel.ymlChecklist
./changelog/fragments
using the changelog toolHow to test this PR locally
Related issues