Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x](backport #6911) Fix NOTICE.txt line endings #6934

Merged
merged 1 commit into from
Feb 21, 2025
Merged

[8.x](backport #6911) Fix NOTICE.txt line endings #6934

merged 1 commit into from
Feb 21, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 19, 2025

What does this PR do?

The NOTICE.txt contains mixed line endings, as produced by mage notice command. This PR adds equivalent of dos2unix NOTICE.txt to the generator to fix this.

Why is it important?

  1. The file is inconsistent to view, whether on unix or windows.
  2. The command mage notice produces incompatible NOTICE.txt changes on windows, which cannot then be fixed by dos2unix, etc, because the CI keeps producing file with mixed line endings.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...
This is an automatic backport of pull request #6911 done by [Mergify](https://mergify.com).

@intxgo @mergify
Fix NOTICE.txt line endings (#6911)
732be01 
* dos2unix NOTICE.txt

* add dos2unix step to notice generator

(cherry picked from commit 467ece4)
@mergify mergify bot requested a review from a team as a code owner February 19, 2025 21:12
@mergify mergify bot added the backport label Feb 19, 2025
@mergify mergify bot requested review from michalpristas and pchila and removed request for a team February 19, 2025 21:12
@mergify mergify bot assigned intxgo Feb 19, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert merged commit 804a3e1 into 8.x Feb 21, 2025
16 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.x/pr-6911 branch February 21, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@intxgo intxgo

Labels
backport Cleanup skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @pierrehilbert @intxgo