Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use secrets from the source of truth #112

Merged
merged 2 commits into from
Jun 26, 2024
Merged

ci: use secrets from the source of truth #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37e0ad8
ci: use secrets from the source of truth
v1v Jun 21, 2024
014d7c1
use the correct secret path
v1v Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ concurrency:
env:
# (keep_serverless-staging-oblt, keep_serverless-qa-oblt or serverless-production-oblt)
SERVERLESS_PROJECT: serverless-production-oblt
# Secrets managed through IasC, if you need a different environment please reach the obs robots team
## TODO: Use Keyless
E2E__BROWSEREMAIL: ${{ secrets.OBSERVABILITY_EC_USERNAME }}
E2E__BROWSERPASSWORD: ${{ secrets.OBSERVABILITY_EC_PASSWORD }}

# NOTE: if you add a new job and it's a mandatory check then
# update e2e-docs.yml
Expand All @@ -51,6 +47,13 @@ jobs:
github-token: ${{ secrets.OBLT_CLI_GITHUB_TOKEN }}
cluster-name: ${{ env.SERVERLESS_PROJECT }}

- uses: google-github-actions/get-secretmanager-secrets@dc4a1392bad0fd60aee00bb2097e30ef07a1caae # v2.1.3
with:
export_to_environment: true
secrets: |-
E2E__BROWSEREMAIL:elastic-observability/elastic-cloud-observability-team-pro-username
E2E__BROWSERPASSWORD:elastic-observability/elastic-cloud-observability-team-pro-password

- name: End-to-end tests
run: ./build.sh test --test-suite=e2e
env:
Expand Down
Loading