Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional build steps in preparation for opensourcing this repo #24

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Add additional build steps in preparation for opensourcing this repo #24

merged 6 commits into from
Jan 16, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jan 15, 2024 •
edited
Loading

This ensures we package and ship a NOTICE.txt alongside the LICENSE.txt we already ship.

This PR now also ensures we print and validate our dependency licenses as part of the build

stevejgordon
stevejgordon approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mpdreamz Mpdreamz merged commit 1548ff4 into main Jan 16, 2024
3 checks passed
@Mpdreamz Mpdreamz deleted the fix/oss branch January 16, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevejgordon stevejgordon stevejgordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mpdreamz @stevejgordon