Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AspNetCore package and registration methods #26

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

stevejgordon
Copy link
Contributor

Adds an initial AspNetCore package that adds the instrumentation by default.

Closes #12

@stevejgordon stevejgordon changed the title Aspnetcore lib Add AspNetCore package and registration methods Jan 18, 2024
Directory.Build.props Outdated Show resolved Hide resolved
/// </summary>
/// <param name="serviceCollection">A <see cref="IServiceCollection"/> to which OpenTelemetry SDK services will be added.</param>
/// <returns>The supplied <see cref="IServiceCollection"/>.</returns>
public IServiceCollection Register(IServiceCollection serviceCollection)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple so nice!

@stevejgordon stevejgordon merged commit 18653e4 into main Jan 18, 2024
3 checks passed
@stevejgordon stevejgordon deleted the aspnetcore-lib branch January 18, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent: Integration with IServiceProvider [Research]
2 participants