Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentelemetry-node): instrumentation-fastify #104

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

david-luna
Copy link
Member

Adds instrumentation of fastify module.

Closes: #40

@david-luna david-luna requested a review from trentm March 26, 2024 19:32
@trentm
Copy link
Member

trentm commented Mar 26, 2024

Oh... test failure on 14.17.

@trentm
Copy link
Member

trentm commented Mar 26, 2024

Oh... test failure on 14.17.

     stack: |-
      Error: Command failed: /opt/hostedtoolcache/node/14.17.6/x64/bin/node ./fixtures/use-fastify.js
      internal/modules/cjs/loader.js:892
        throw err;
        ^
      
      Error: Cannot find module 'node:events'
      Require stack:
      - /home/runner/work/elastic-otel-node/elastic-otel-node/node_modules/avvio/boot.js
      - /home/runner/work/elastic-otel-node/elastic-otel-node/node_modules/fastify/fastify.js
      - /home/runner/work/elastic-otel-node/elastic-otel-node/packages/opentelemetry-node/test/fixtures/use-fastify.js
          at Function.Module._resolveFilename (internal/modules/cjs/loader.js:889:15)

And node: prefix was added in node v14.18.0 (https://nodejs.org/api/modules.html#core-modules).
It would be nice if fastify and other modules maintained an "engines" promise, but that's more work.

So I guess this needs to skip tests for <14.18.0

@trentm trentm merged commit 735d757 into main Mar 27, 2024
11 checks passed
@trentm trentm deleted the dluna/40-fastify-instrumentation branch March 27, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add @opentelemetry/instrumentation-fastify instrumentation
2 participants