Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instrumentation API and native OpenTelemetry implementation #18

Merged
merged 12 commits into from
Dec 19, 2023
Merged

Add instrumentation API and native OpenTelemetry implementation #18

merged 12 commits into from
Dec 19, 2023

Conversation

Anaethelion
Copy link
Contributor

This adds an Instrumentation interface to the transport and a first implementation based on OpenTelemetry.

@Anaethelion Anaethelion assigned swallez and unassigned swallez Dec 14, 2023
swallez
swallez approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a comment on a possible naming improvement.

elastictransport/instrumentation.go Outdated Show resolved Hide resolved
@Anaethelion Anaethelion merged commit 903383c into main Dec 19, 2023
14 checks passed
@Anaethelion Anaethelion deleted the otel_integration branch December 19, 2023 15:46
@Anaethelion Anaethelion mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swallez swallez swallez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anaethelion @swallez