refactor/request data v3 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RequestData is now used as a bound instance over `ITransportConfiguration` and `IRequestConfiguration` record versions of `TransportConfiguration` and `RequestConfiguration` now exists You can create a new instance of `TransportConfiguration` based off another (with test that all properties get assigned) Ensure only `RequestData` deals is in charge of dealing with global and local configuration. The meant some updates to our request pipelines. We now use a single `RequestData` instance if no per request overrides are provided
Refactor to decouple date provider and introduce Auditor usage. Renamed and altered functions within pipeline components to utilize the `Auditor` class, improving flexibility and modularity. Removed the embedded `DateTimeProvider` instance from several classes and ensured that such dependencies are injected or fetched through associated components like the node pools. This change enhances monitoring and logging capabilities during request processing. Adjust time tolerance in TransportConfigurationTests Increased the time tolerance for the 'LastUpdate' field comparison from 100 milliseconds to 2 seconds. This change enhances the reliability of the test by accommodating larger variations in timing. (cherry picked from commit 14207cb) Simplify RequestPipeline and reuse a singleton instance if we can Add DateTimeProvider and RequestPipelineFactory properties This commit introduces `DateTimeProvider` and `RequestPipelineFactory` properties to the transport configuration. The changes ensure that these properties are properly initialized and accessed throughout various components, enhancing configurability and testability of date and request pipeline behaviors.
Mpdreamz
force-pushed
the
refactor/request-data-v3
branch
from
6aee59f to
95ea6c6
Compare
Information is read at a later time from RequestData which is now likely a static instance.
stevejgordon
requested changes
Nov 7, 2024
src/Elastic.Transport/Configuration/TransportConfigurationDescriptor.cs
Outdated
Show resolved
Hide resolved
|
Great nits! Upated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #128 and ensures
RequestPipelinecan be shared over many requests unless a local configuration is provided.Similar to
RequestDatabeing shared in #128.This includes further refactorings:
DateTimeProvideris only provided externally once (onNodePool) and that instance is used everywhere. Before it could be set seperately onNodePoolandTransportConfiguration, not by design but by necessity.RequestPipelineis no longer disposable (we didn't actually disposed anything).A new type exists
Auditorthis is now explicitly passed to the methods that need it onRequestPipeline. It implementsIReadOnlyCollection<Audit>and is exposed as such to users.This PR also merges
DefaultRequestPipelineandRequestPipelineinto one.