Refactor OpenTelemetryData to Action<Activity> #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows consumers such as ingest to record the actual number of operations.
flobernd
reviewed
Nov 21, 2024
| if (attribute.Key.Equals(OpenTelemetryAttributes.DbElasticsearchSchemaUrl, StringComparison.Ordinal)) | ||
| { | ||
| if (attribute.Value is string schemaVersion) | ||
| productSchemaVersion = schemaVersion; |
There was a problem hiding this comment.
@stevejgordon Removing this causes the condition in line 69 to be always true.
flobernd
reviewed
Nov 21, 2024
| /// <summary> | ||
| /// The name to use for spans relating to a request. | ||
| /// </summary> | ||
| public string? SpanName { get; init; } |
There was a problem hiding this comment.
@stevejgordon How am I supposed to set a custom OperationName with the new design? The property has no setter. Should I use DisplayName to modify it?
There was a problem hiding this comment.
Update: DisplayName does not update the original OperationName which causes a test to fail in the client library. We have to re-introduce a way to provide the OperationName.
A potential solution would be to bring back OpenTelemetryData, but modify it to, besides OperationName, have the current Action<> as a property instead of the previous "attributes" dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142