-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt at renames #96
Conversation
Mpdreamz
commented
Aug 30, 2023
•
edited
Loading
edited
- TransportClient => interface IRequestInvoker
- HttpTransport => interface ITransport
- DefaultHttpTransport => DistributedTransport
9693219
to
105955f
Compare
Without diving into the details, I took a quick scan of this. I generally like much of the renaming here. I like separating the logical transport concept from the IO detail of invoking the requests. I'm generally in favour of preferring abstract classes over interfaces on things we may evolve. This change will conflict with some refactoring I've done in my WIP branch to update the OTel instrumentation. For example, |
In general I like this move to abstract classes with transport specifically though I really miss a covariant interface so base classes can expose the injected concrete configuration rather then the the (abstract) base implementation. The other was by explicitly naming |
c64fed2
to
918a58c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!