Skip to content

Conversation

ugosan
Copy link

@ugosan ugosan commented Oct 3, 2025

Copy link

gitnotebooks bot commented Oct 3, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/493

@justincastilla
Copy link
Contributor

@ugosan added some style suggestions to match searchlabs notebook conventions. Also can you use the elasticsearch client instead of requests for this, please?

Other than that, looks pretty good!

ugosan and others added 5 commits October 6, 2025 09:10
…s/notebook.ipynb

Co-authored-by: Justin Castilla <59704472+justincastilla@users.noreply.github.com>
Co-authored-by: Justin Castilla <59704472+justincastilla@users.noreply.github.com>
@ugosan
Copy link
Author

ugosan commented Oct 6, 2025

thanks @justincastilla , updated!

"outputs": [],
"source": [
"# Credentials - Enter your API keys securely\n",
"ELASTICSEARCH_URL = input(\"Enter your Elasticsearch URL: \").strip()\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ELASTICSEARCH_URL = input(\"Enter your Elasticsearch URL: \").strip()\n",
"ELASTICSEARCH_URL = getpass.getpass(\"Enter your Elasticsearch URL: \").strip()\n",

@justincastilla
Copy link
Contributor

@ugosan Just one last minor change and it's good to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants