fix #4029: Use enum item.Name instead of Enum.GetName to get enum value #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the propsed fix from the original repo of the code: neuecc/Utf8Json#129
|
Thanks for opening this, @sklirg 👍 Targeting master is best, we can backport to 7.x then. |
|
ported to 7.x: 7d974ac |
|
Is there a planned release that includes this fix in the near future? :-) Would love to have this in our testing environment to make sure our upgrade to 7.x works smoothly in production as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the propsed fix from the original repo of the code: neuecc/Utf8Json#129
Resolves #4029
I've tested this locally in a .NET Framework project and it works, compared to previously where it'd throw with an exception as mentioned in #4029.
I'm not sure if this should target 7.x or the master branch.