Skip to content

Xpack settings fixes #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Xpack settings fixes #2998

merged 2 commits into from
Oct 14, 2024

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Oct 9, 2024

The ml field in NodeInfoXpackSecurity is used in start-local.
A java user reported that having an anonymous realm means the realm field is null (and according to the documentation, probably also the token field).

Unfortunately I couldn't find any server side proof, let's see what the validation says.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
nodes.info 🔴 114/114 1/114

You can validate this API yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
nodes.info 🔴 114/114 1/114

You can validate this API yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@l-trotta l-trotta merged commit 0259789 into main Oct 14, 2024
7 checks passed
@l-trotta l-trotta deleted the xpack-settings-fixes branch October 14, 2024 09:38
github-actions bot pushed a commit that referenced this pull request Oct 14, 2024
* xpack settings fixes

* correct ml place

(cherry picked from commit 0259789)
l-trotta added a commit that referenced this pull request Oct 14, 2024
* xpack settings fixes

* correct ml place

(cherry picked from commit 0259789)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants