Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Nov 17, 2025

The purpose is to add enough data to generate the rest-api-spec, but not more, as those APIs are private.

The purpose is to add enough data to generate the rest-api-spec.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Following you can find the validation changes against the target branch for the APIs.

API Status Request Response
_internal.delete_desired_balance ➕ 🟢 1/1 1/1
_internal.delete_desired_nodes ➕ 🟢 1/1 1/1
_internal.get_desired_balance ➕ 🟢 10/10 10/10
_internal.get_desired_nodes ➕ 🟢 17/17 17/17
_internal.prevalidate_node_removal ➕ 🔴 0/2 2/2
_internal.update_desired_nodes ➕ 🔴 16/17 17/17
profiling.flamegraph ➕ ⚪ Missing test Missing test
profiling.stacktraces ➕ ⚪ Missing test Missing test
profiling.status ➕ ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

They are only here for the purpose of generating rest-api-spec files, so a lot
of the content is empty.
@MattDevy
Copy link
Contributor

Some linter errors and need to run prettier, but otherwise LGTM

Copy link
Contributor

@MattDevy MattDevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pquentin pquentin changed the title Add profiling stubs Add profiling and _internal stubs Nov 21, 2025
@pquentin pquentin merged commit 5f707db into main Nov 21, 2025
12 checks passed
@pquentin pquentin deleted the profiling-specification branch November 21, 2025 14:40
@github-actions
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5686-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f707dbb77b8cda8a97ab02fad08b15f73d06ef1
# Push it to GitHub
git push --set-upstream origin backport-5686-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5686-to-8.19.

@github-actions
Copy link
Contributor

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5686-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f707dbb77b8cda8a97ab02fad08b15f73d06ef1
# Push it to GitHub
git push --set-upstream origin backport-5686-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-5686-to-9.1.

@github-actions
Copy link
Contributor

The backport to 9.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5686-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f707dbb77b8cda8a97ab02fad08b15f73d06ef1
# Push it to GitHub
git push --set-upstream origin backport-5686-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2

Then, create a pull request where the base branch is 9.2 and the compare/head branch is backport-5686-to-9.2.

pquentin added a commit that referenced this pull request Nov 24, 2025
* Add profiling stubs

The purpose is to add enough data to generate the rest-api-spec.

* Add _internal endpoints

They are only here for the purpose of generating rest-api-spec files, so a lot
of the content is empty.

* Fix lint

* Update tsconfig.json

* Run make contrib

(cherry picked from commit 5f707db)

# Conflicts:
#	output/schema/validation-errors.json
pquentin added a commit that referenced this pull request Nov 24, 2025
* Add profiling stubs

The purpose is to add enough data to generate the rest-api-spec.

* Add _internal endpoints

They are only here for the purpose of generating rest-api-spec files, so a lot
of the content is empty.

* Fix lint

* Update tsconfig.json

* Run make contrib

(cherry picked from commit 5f707db)

# Conflicts:
#	output/schema/validation-errors.json
#	output/typescript/types.ts
#	specification/tsconfig.json
pquentin added a commit that referenced this pull request Nov 24, 2025
* Add profiling stubs

The purpose is to add enough data to generate the rest-api-spec.

* Add _internal endpoints

They are only here for the purpose of generating rest-api-spec files, so a lot
of the content is empty.

* Fix lint

* Update tsconfig.json

* Run make contrib

(cherry picked from commit 5f707db)

# Conflicts:
#	output/schema/validation-errors.json
#	output/typescript/types.ts
#	specification/_doc_ids/table.csv
#	specification/tsconfig.json
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
9.2
9.1
8.19

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Nov 24, 2025
* Add profiling stubs

The purpose is to add enough data to generate the rest-api-spec.

* Add _internal endpoints

They are only here for the purpose of generating rest-api-spec files, so a lot
of the content is empty.

* Fix lint

* Update tsconfig.json

* Run make contrib

(cherry picked from commit 5f707db)

# Conflicts:
#	output/schema/validation-errors.json
pquentin added a commit that referenced this pull request Nov 24, 2025
* Add profiling stubs

The purpose is to add enough data to generate the rest-api-spec.

* Add _internal endpoints

They are only here for the purpose of generating rest-api-spec files, so a lot
of the content is empty.

* Fix lint

* Update tsconfig.json

* Run make contrib

(cherry picked from commit 5f707db)

# Conflicts:
#	output/schema/validation-errors.json
#	output/typescript/types.ts
#	specification/tsconfig.json
pquentin added a commit that referenced this pull request Nov 24, 2025
* Add profiling stubs

The purpose is to add enough data to generate the rest-api-spec.

* Add _internal endpoints

They are only here for the purpose of generating rest-api-spec files, so a lot
of the content is empty.

* Fix lint

* Update tsconfig.json

* Run make contrib

(cherry picked from commit 5f707db)

# Conflicts:
#	output/schema/validation-errors.json
#	output/typescript/types.ts
#	specification/_doc_ids/table.csv
#	specification/tsconfig.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants