-
Notifications
You must be signed in to change notification settings - Fork 115
Add profiling and _internal stubs #5686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The purpose is to add enough data to generate the rest-api-spec.
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
They are only here for the purpose of generating rest-api-spec files, so a lot of the content is empty.
|
Some linter errors and need to run prettier, but otherwise LGTM |
MattDevy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5686-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f707dbb77b8cda8a97ab02fad08b15f73d06ef1
# Push it to GitHub
git push --set-upstream origin backport-5686-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5686-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f707dbb77b8cda8a97ab02fad08b15f73d06ef1
# Push it to GitHub
git push --set-upstream origin backport-5686-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5686-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f707dbb77b8cda8a97ab02fad08b15f73d06ef1
# Push it to GitHub
git push --set-upstream origin backport-5686-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2Then, create a pull request where the |
* Add profiling stubs The purpose is to add enough data to generate the rest-api-spec. * Add _internal endpoints They are only here for the purpose of generating rest-api-spec files, so a lot of the content is empty. * Fix lint * Update tsconfig.json * Run make contrib (cherry picked from commit 5f707db) # Conflicts: # output/schema/validation-errors.json
* Add profiling stubs The purpose is to add enough data to generate the rest-api-spec. * Add _internal endpoints They are only here for the purpose of generating rest-api-spec files, so a lot of the content is empty. * Fix lint * Update tsconfig.json * Run make contrib (cherry picked from commit 5f707db) # Conflicts: # output/schema/validation-errors.json # output/typescript/types.ts # specification/tsconfig.json
* Add profiling stubs The purpose is to add enough data to generate the rest-api-spec. * Add _internal endpoints They are only here for the purpose of generating rest-api-spec files, so a lot of the content is empty. * Fix lint * Update tsconfig.json * Run make contrib (cherry picked from commit 5f707db) # Conflicts: # output/schema/validation-errors.json # output/typescript/types.ts # specification/_doc_ids/table.csv # specification/tsconfig.json
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Add profiling stubs The purpose is to add enough data to generate the rest-api-spec. * Add _internal endpoints They are only here for the purpose of generating rest-api-spec files, so a lot of the content is empty. * Fix lint * Update tsconfig.json * Run make contrib (cherry picked from commit 5f707db) # Conflicts: # output/schema/validation-errors.json
* Add profiling stubs The purpose is to add enough data to generate the rest-api-spec. * Add _internal endpoints They are only here for the purpose of generating rest-api-spec files, so a lot of the content is empty. * Fix lint * Update tsconfig.json * Run make contrib (cherry picked from commit 5f707db) # Conflicts: # output/schema/validation-errors.json # output/typescript/types.ts # specification/tsconfig.json
* Add profiling stubs The purpose is to add enough data to generate the rest-api-spec. * Add _internal endpoints They are only here for the purpose of generating rest-api-spec files, so a lot of the content is empty. * Fix lint * Update tsconfig.json * Run make contrib (cherry picked from commit 5f707db) # Conflicts: # output/schema/validation-errors.json # output/typescript/types.ts # specification/_doc_ids/table.csv # specification/tsconfig.json
The purpose is to add enough data to generate the rest-api-spec, but not more, as those APIs are private.