Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apm-data: set codec: best_compression for logs-apm.* data streams #108862

Merged
merged 6 commits into from
May 23, 2024

Conversation

endorama
Copy link
Member

@endorama endorama commented May 21, 2024

Set codec: best_compression on logs related data streams for apm-data plugin. This aligns the configuration to what happens when using the apm integration package.

This setting is set by Fleet (see issue) to reduce storage for ingested data. We want to retain the same behaviour with the integration.

Note that best_compression codec is already used for metrics but not for traces, for which we will evaluate enabling it at a later moment.

Rel: elastic/apm-server#11529

@endorama endorama requested a review from a team as a code owner May 21, 2024 13:42
@elasticsearchmachine elasticsearchmachine added v8.15.0 needs:triage Requires assignment of a team area label labels May 21, 2024
@axw axw added >enhancement :Data Management/Data streams Data streams and their lifecycles labels May 22, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label May 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 22, 2024
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs an update to resources.yaml. You can run the tests for the apm-data plugin with these commands:

./gradlew x-pack:plugin:apm-data:test
./gradlew x-pack:plugin:apm-data:yamlRestTest

@elasticsearchmachine
Copy link
Collaborator

Hi @endorama, I've created a changelog YAML for you.

Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
@endorama endorama merged commit 8bca164 into elastic:main May 23, 2024
15 checks passed
@endorama endorama deleted the apm-data-fix-codec branch May 23, 2024 09:58
@endorama endorama changed the title apm-data: set codec apm-data: set codec: best_compression for logs-apm.* data streams May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Data streams Data streams and their lifecycles >enhancement Team:Data Management Meta label for data/management team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants